feat(ssr-client-hints): nested cookie config for color scheme#367
Merged
Conversation
…complexity in check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reshapes the color-scheme cookie configuration under
prefersColorSchemeOptionsinto a nestedcookie: {}object and adds control overSecure/SameSite.prefersColorSchemeOptions.cookie?: { name?, domain?, secure?, sameSite? }.cookieNameis kept but deprecated (maps tocookie.name; emits one build-time warning when used). When both are set,cookie.namewins.cookieDomainoption is removed — usecookie.domain.secureandsameSitewere previously hardcoded (SameSite=Lax, noSecure); they are now configurable.secureis forced totruewhensameSiteis'none'.Default behaviour is unchanged:
cookie.namedefaults tocolor-scheme,SameSite=Lax, noSecure, noDomain.Implementation notes
cookieobject; the resolved/runtime config stays flat (cookieName,cookieDomain,cookieSecure,cookieSameSite) to keep the runtime plugins simple.prepareSSRClientHints, extracted into a smallresolveColorSchemeCookiehelper.Test Plan
prepareSSRClientHintsnormalisation: nested-only, legacy-only (warns), both (new wins), defaults,sameSite:'none'forcessecure.dev:prepare) clean.